Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132517 / 24.10.1 / Cloud credentials storJ text does not render link correctly (by AlexKarpov98) #11061

Merged
merged 2 commits into from
Nov 18, 2024
Merged

NAS-132517 / 24.10.1 / Cloud credentials storJ text does not render link correctly (by AlexKarpov98) #11061

merged 2 commits into from
Nov 18, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x cf3d06f2733ecab7c26d2a109eaeb7e0a8b82fe1

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 8611b31c7805968a471a9c700fcb31547508680b

Code review is enough
Screenshot 2024-11-18 at 11 06 26

Original PR: #11055
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132517

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review November 18, 2024 13:02
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner November 18, 2024 13:02
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team November 18, 2024 13:02
AlexKarpov98
AlexKarpov98 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@9cb82d8). Learn more about missing BASE report.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##             stable/electriceel   #11061   +/-   ##
=====================================================
  Coverage                      ?   79.98%           
=====================================================
  Files                         ?     1572           
  Lines                         ?    51441           
  Branches                      ?     5938           
=====================================================
  Hits                          ?    41145           
  Misses                        ?    10296           
  Partials                      ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 06eb4d0 into stable/electriceel Nov 18, 2024
7 checks passed
@undsoft undsoft deleted the NAS-132517-24.10.1 branch November 18, 2024 13:48
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

@bvasilenko bvasilenko Awaiting requested review from bvasilenko bvasilenko is a code owner automatically assigned from truenas/ui-team

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugclerk @AlexKarpov98 @undsoft